fix(transloco): 🐛 fixed generated scope name in subdirectories#738
Closed
JordanW9232 wants to merge 2 commits intojsverse:masterfrom
Closed
fix(transloco): 🐛 fixed generated scope name in subdirectories#738JordanW9232 wants to merge 2 commits intojsverse:masterfrom
JordanW9232 wants to merge 2 commits intojsverse:masterfrom
Conversation
|
|
1 task
Collaborator
|
@JordanW9232 Please refer to my comment here |
shaharkazaz
force-pushed
the
master
branch
5 times, most recently
from
c068fa2 to
d2ade9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 559
What is the new behavior?
Using a file in a nested directory such as "i18n/nested-scopes/admin-page/en.json" will generate the scope name as "nestedScope.adminPage" rather than "nestedScopeAdminPage".
Does this PR introduce a breaking change?
Other information